Fix interface injection deduplication when all injected interfaces are already present#58
Merged
shartte merged 1 commit intoneoforged:mainfrom Dec 14, 2025
Merged
Conversation
…e already present
|
Matyrobbrt
approved these changes
Dec 14, 2025
|
🚀 This PR has been released as JavaSourceTransformer version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a spurious
,after the implements list when all injected interfaces on a class have been removed through deduplication because they were already present.Example:
A class already implements
java.util.Set. Trying to injectjava.util.Setleads toclass C implements Set, {